Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter fails when sectids are disabled #70

Closed
mojavelinux opened this issue Dec 10, 2014 · 3 comments
Closed

Converter fails when sectids are disabled #70

mojavelinux opened this issue Dec 10, 2014 · 3 comments
Assignees
Labels

Comments

@mojavelinux
Copy link
Member

When the sectids attribute is disabled, the converter fails when attempting to create internal cross references (destinations).

The likely solution is to force sectids to be enabled when using the PDF converter. We could also assign a random id if one is not already assigned. The values are meaningless to the user.

@mojavelinux mojavelinux self-assigned this Dec 10, 2014
@mojavelinux mojavelinux added this to the v1.5.0 milestone Dec 10, 2014
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 17, 2015
- don't crash if sectids are disabled
- get links from TOC and outline working when sectids are disabled
@mojavelinux
Copy link
Member Author

I decided to introduce a new attribute named 'anchor' that is assigned to the id of the section, if it exists, otherwise an auto-generated value.

I added stub code for reenabling generated section ids if we decided to go that route.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 18, 2015
- don't crash if sectids are disabled
- get links from TOC and outline working when sectids are disabled
mojavelinux added a commit that referenced this issue May 25, 2015
resolves #70 don't crash if sectids attribute is disabled
@mojavelinux
Copy link
Member Author

mojavelinux commented Apr 18, 2016

This issue appears to be back. See #419.

@mojavelinux
Copy link
Member Author

Fixed once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants