Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attribute or role to control table row shading #724

Closed
mojavelinux opened this issue Jan 7, 2017 · 2 comments
Closed

Add attribute or role to control table row shading #724

mojavelinux opened this issue Jan 7, 2017 · 2 comments
Assignees
@mojavelinux
Labels
enhancement
Milestone
v1.5.0.alpha.15

Comments

@mojavelinux
Copy link
Member

Add either an attribute or a role (or both) to control table row shading (aka striping). Currently, this behavior is controlled by the theme, but it would be convenient to be able to control it per table as there are times when the table is not being used for data.

The proposed role name is "striped".

The proposed attribute name is stripe (stripe=even, stripe=odd, stripe=none, stripe=all). Since there are four distinct patterns, I think an attribute makes more sense. It also aligns nicely with frame and grid.
@mojavelinux mojavelinux added this to the v1.5.0.alpha.15 milestone Jan 7, 2017
@mojavelinux mojavelinux self-assigned this Jan 7, 2017
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Feb 7, 2017
@mojavelinux
resolves asciidoctor#724 introduce attribute to control table striping
b49d033 
- add stripe role to control table striping
- values are even (default), odd, all, none
- introduce keys to control striping
- table_body_background_color is "off" value; odd rows by default
- table_body_stripe_background_color is "on" value; even rows by default
mojavelinux added a commit that referenced this issue Feb 17, 2017
@mojavelinux
follow-up to #724 document new theme keys to control table striping
4dc7d6f 
- document table_body_background_color & table_body_stripe_background_color
- set default value for table_body_stripe_background_color in base theme
@mojavelinux
Copy link
Member Author

I wonder if this attribute should be called stripe, stripes, or striping. Anyone have any insight to share?

stripe=odd

vs

stripes=odd

vs

striping=odd

@mojavelinux
Copy link
Member Author

I decided to use the attribute "stripes". We'll see how that feels and change it later if it doesn't work out.

@miltador miltador mentioned this issue Apr 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
enhancement
Projects
None yet
Milestone
v1.5.0.alpha.15
Development

No branches or pull requests
1 participant
@mojavelinux