Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #73 refs #85. Append footnotes at document end #1010

Closed
wants to merge 1 commit into from

Conversation

bcourtine
Copy link

Footnotes are not inlined anymore. They are appened at document end, with bi-directional links between document and notes.

It is not perfect (footnotes are not at page end), but I think it is better than the current situation.

@bcourtine bcourtine changed the title refs #927 Append footnotes at document end refs #73 Append footnotes at document end Mar 22, 2019
@bcourtine bcourtine changed the title refs #73 Append footnotes at document end refs #73 refs #85. Append footnotes at document end Mar 22, 2019
@mojavelinux
Copy link
Member

Thank you for getting the ball rolling on this, @bcourtine! I have proposed a revised implementation based on this work in PR #1016. Please give it a try and let me know how it work out.

The main differences are that a) the footnotes added in a chapter are placed at the end of that chapter when the doctype is book, b) it uses the same convention for generating IDs as is used in core, c) changes the heading to a block title, adding it only if footnotes-title is set, and c) adds rudimentary theme control.

@mojavelinux
Copy link
Member

I'm closing this in favor of #1016, which builds on this proposal.

@mojavelinux mojavelinux closed this Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants