resolves #121. Admonition icon customization by theme. #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent work @jessedoyle! I'm eager to try it out! |
mojavelinux
added a commit
to mojavelinux/asciidoctor-pdf
that referenced
this pull request
Oct 12, 2015
- change how admonition icon data is stored in theme - properly evaluate and convert icon data values - rename :key to :name in icon hash - rename :color to :stroke_color in icon hash - simplify and consolidate logic
- change how admonition icon data is stored in theme - properly evaluate and convert icon data values - rename :key to :name in icon hash - rename :color to :stroke_color in icon hash - simplify and consolidate logic
optimize custom admonition implementation. asciidoctor#332
|
This is fantastic! Such a great addition! |
mojavelinux
added a commit
that referenced
this pull request
Oct 13, 2015
resolves #121. Admonition icon customization by theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows for admonition icon customization via the pdf theme.
Here's an example of the theme syntax:
Supported icon keys currently are:
key,colorandsize. If any of these are not specified, they will remain as the Asciidoctor defaults.I haven't tested the patch to ensure that I haven't broken something, so it's probably best to double-check that everything works okay!