Fixes #259 - Sidebars now render on multiple pages #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sort of hack (which my last attempted fix *did* do).
ghost
mentioned this pull request
|
Gah, false alarm, accidentally looking at the wrong spec build... getting closer though! |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code to render sidebars over multiple pages correctly. It does result in text existing in the document twice (as the last fix did - #735), which is a bit annoying, but it only really affects text searches and document size afaict.
A better fix is theoretically possible, but it would require significant reworking of the pdf renderer - the using the "dry_run" attribute, for instance.
Fix refactors convert_sidebar to mirror behaviour of convert_quote_or_verse, such that multiple pages draw correctly. Requires drawing the block content twice.
Fixes #259