Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#609]fix: adds border to last-child colspanned cells for better merged-cell styling #706

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[#609]fix: adds border to last-child colspanned cells for better merged-cell styling #706

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a72195
(#678 , #680)feat: add ability for asciidocParser to pass the krokiSe…
haydencbarnes Feb 10, 2023
f9e59e7
(#701)fix: add comma to new AsciidoctorWebViewConverter constructors
haydencbarnes Feb 10, 2023
8e2e9f6
[#609]fix: adds border to last-child colspanned cells for better merg…
haydencbarnes Feb 16, 2023
c1be768
Merge branch 'asciidoctor:master' into master
haydencbarnes Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions media/asciidoctor-editor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,6 +1672,18 @@ table.grid-all>*>tr>.tableblock:last-child,
table.grid-cols>*>tr>.tableblock:last-child {
border-right-width: 0
}
/* git issue - https://github.com/asciidoctor/asciidoctor-vscode/issues/609
If the last child cell was merged in the middle of three columns, then the middle cell of the three columns (but really last child cell)
would not contain a right side border due to css "thinking" the cell was the most right cell and therefor be bordered by
the frame element below this all.
table.grid-cols>*>tr>.tableblock[colspan]:last-child (below) sets a 1-pixel wide right border for the last cell in each row with a
colspan attribute. This is needed because table.grid-all>*>tr>.tableblock:last-child removes the border from the last cell,
but in the case of merged cells the border is actually needed. Note: This may cause a small double border on the bottom
most right cell of a colspanned row if it ends in the furthest right column.
*/
table.grid-cols>*>tr>.tableblock[colspan]:last-child {
border-right-width: 1px;
}

table.grid-all>tbody>tr:last-child>.tableblock,
table.grid-all>thead:last-child>tr>.tableblock,
Expand Down