Fix non working xref in preview pane #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During testing `cacheImageSizes` always triggered events even though there were no images in the document.
ggrossetie
reviewed
Mar 12, 2024
ggrossetie
reviewed
Mar 12, 2024
ViToni
force-pushed
the
bugfix/fix_non-working_xref_preview_pane
branch
from
ee1eabf
to
e464a57
Compare
ViToni
force-pushed
the
bugfix/fix_non-working_xref_preview_pane
branch
from
e464a57
to
da585df
Compare
ViToni
force-pushed
the
bugfix/fix_non-working_xref_preview_pane
branch
3 times, most recently
from
30601d9
to
a509fc5
Compare
ViToni
force-pushed
the
bugfix/fix_non-working_xref_preview_pane
branch
from
2a9583f
to
58eac4f
Compare
|
All good, thanks 👍🏻 |
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
xref:andlink:create<a>elements. Forxref:thedata-hrefattribute was missing so WebView didn't treat it as a regular link. Nowxref:andlink:are created the same way for the WebView thus allowingxref:navigation.Resolves #425.