Bump org.apache.pdfbox:pdfbox to v3.0.0 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only updates test utilities
|
Thank you! |
abelsromero
added a commit
to abelsromero/asciidoctorj
that referenced
this pull request
Sep 6, 2023
* Port of asciidoctor/asciidoctorj-pdf#96 * Only afects test utilities
5 tasks
abelsromero
added a commit
to abelsromero/asciidoctorj
that referenced
this pull request
Sep 6, 2023
* Port of asciidoctor/asciidoctorj-pdf#96 * Only affects test utilities
abelsromero
added a commit
to abelsromero/asciidoctorj
that referenced
this pull request
Sep 7, 2023
* Port of asciidoctor/asciidoctorj-pdf#96 * Only affects test utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only updates test utilities, no impact in production code.
Thank you for opening a pull request and contributing to AsciidoctorJ PDF!
Please take a bit of time giving some details about your pull request:
Kind of change
[ ] Bug fix
[x] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[x] Build improvement
Description
What is the goal of this pull request?
Bump to the latest Apache PDFBox, I fixed some v2->v3 breakages in maven-examples and remembered this project has still in v1.8 😱
How does it achieve that?
Bump and rewrite test utilities with newer APIS. Kudos to the Apache PDFBox team and the examples they provide.
Are there any alternative ways to implement this?
No
Are there any implications of this pull request? Anything a user must know?
No
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc
These changes are internals, not relevant for the changelog.