-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Options and Attributes creation #1015
Simplify Options and Attributes creation #1015
Conversation
Make compatible changes to guide users for future changes
I must say, IMHO, that with this changes the interaction is much nicer to the point that I think most new users should be able to do a test without checking the docs. |
This reduces the number of convert methods from 21 to 7 😄 |
I saw for load we only accept Maps asciidoctorj/asciidoctorj-api/src/main/java/org/asciidoctor/Asciidoctor.java Lines 520 to 536 in 6523da8
|
…plify-Options-and-Attributes
Thank you for this, this is great! |
...and add a PR that makes Asciidoctor.load() accept an instance of |
Exactly 😄 just let me add that later today and we should be good to go! |
Make compatible changes to guide users for future changes
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
Make the experience interacting with Asciidoctor API simpler and less confusing, while mantaining compatibility with current methods and types.
How does it achieve that?
Marks non-prefered methods as deprecated, so users can strt applying changes.
Are there any alternative ways to implement this?
In terms of making the changes smooth no.
Are there any implications of this pull request? Anything a user must know?
No
Issue
If this PR fixes an open issue, please add a line of the form:
Related to #977 but does not close it completely.
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc