Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: doc-testでSyntaxエラーをFailにする #151

Closed
azu opened this issue Oct 12, 2016 · 0 comments · Fixed by #157
Closed

test: doc-testでSyntaxエラーをFailにする #151

azu opened this issue Oct 12, 2016 · 0 comments · Fixed by #157

Comments

@azu
Copy link
Collaborator

azu commented Oct 12, 2016

https://github.com/asciidwango/js-primer/blob/master/test/markdown-doc-test.js
でSyntax Errorをわざと無視してる。
けどサンプルコードにSyntaxErrorが混ざることを許容してしまうので、SyntaxErrorも例外にする。

Syntax Errorは https://github.com/asciidwango/js-primer/blob/master/test/invalid-test.js で書くことにする
@azu azu mentioned this issue Oct 28, 2016
Closed
azu added a commit that referenced this issue Nov 1, 2016
@azu
fix(test): invalidなコードは-invalid.jsへ移す
34e2b6d 
Markdown中のコードは必ず実行できるように。
ReferenceErrorは解説用のコードのための無視する

close #151
@azu azu mentioned this issue Nov 1, 2016
Merged
@azu azu closed this as completed in #157 Nov 1, 2016
azu added a commit that referenced this issue Nov 1, 2016
@azu
fix(test): invalidなコードは-invalid.jsへ移す (#157)
27cc54c 
Markdown中のコードは必ず実行できるように。
ReferenceErrorは解説用のコードのための無視する

close #151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test): SyntaxErrorなコードは-invalid.jsへ移す asciidwango/js-primer
1 participant
@azu