Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1479 fix ecma url #1487

Merged
merged 4 commits into from
Oct 15, 2022
Merged

Conversation

harukitosa
Copy link
Contributor

@harukitosa harukitosa commented Oct 15, 2022

#1479

使用されている箇所は https://tc39.es/ecma262/ に変更しました!
ご確認お願いします。(READMEのみでよければ別途その変更のみのprを作ります)

@bot-user
Copy link

bot-user commented Oct 15, 2022

Deploy Preview for js-primer ready!

Name Link
🔨 Latest commit a67e5de
🔍 Latest deploy log https://app.netlify.com/sites/js-primer/deploys/634a793404c5300009d9fec1
😎 Deploy Preview https://deploy-preview-1487--js-primer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

.textlintrc.js Outdated
// .es が正式なのか不明であるため
// https://github.com/tc39/ecma262/pull/1576
"https:/tc39.github.io/**"
"https://tc39.es/ecma262/**"
Copy link
Collaborator

@azu azu Oct 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これはリダイレクトの検知防止なので単純に https:/tc39.github.io/** を削除で大丈夫だと思います。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました!
5ded998
a67e5de

This reverts commit d56ad16.
@@ -40,7 +40,7 @@ ES5.1からES2015がでるまで4年もの歳月がかかっているのに対
## Living StandardとなるECMAScript {#living-standard}

現在、ECMAScriptの仕様書のドラフトはGitHub上の[tc39/ecma262][]で管理されており、日々更新されています。
そのため、本当の意味での最新のECMAScript仕様は<https://tc39.github.io/ecma262/>となります。
そのため、本当の意味での最新のECMAScript仕様は<https://tc39.es/ecma262/>となります。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 本文的な変更箇所

Copy link
Collaborator

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ありがとうございました!

@azu azu merged commit 8b253f6 into asciidwango:master Oct 15, 2022
@azu azu mentioned this pull request Oct 15, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants