Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ajax): externalResourcesではなく、動的に末尾にglobalThisでグローバルに関数を追加した #1521

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

azu
Copy link
Collaborator

@azu azu commented Nov 5, 2022

globalThis.fetchUserInfo = fetchUserInfo; を末尾に動的に作って追加することで、onclick="fetchUserInfo()" が動くようにした

fix #1423
fix #1520

@bot-user
Copy link

bot-user commented Nov 5, 2022

Deploy Preview for js-primer ready!

Name Link
🔨 Latest commit 956c050
🔍 Latest deploy log https://app.netlify.com/sites/js-primer/deploys/63666d5fc9d1ab000a2543f7
😎 Deploy Preview https://deploy-preview-1521--js-primer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@azu azu merged commit bcdbff7 into master Nov 5, 2022
@azu azu deleted the feature/1520 branch November 5, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ajax: sandpackのexternalResources だと編集ができない
2 participants