Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise IncrementalCacheManager.java #504

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Dec 22, 2024

Remove check for deleted files since the full rebuild check in 2.8.0 will already cover this eventuality, making the additional work redundant.

Remove check for deleted files since the full rebuild check in 2.8.0
will already cover this eventuality, making the additional work
redundant.
@ascopes ascopes added the general improvements Fixing/updating internal components and code label Dec 22, 2024
@ascopes ascopes added this to the v2.8.x milestone Dec 22, 2024
@ascopes ascopes self-assigned this Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (ef234bd) to head (3c5c56d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   87.31%   87.56%   +0.26%     
==========================================
  Files          40       40              
  Lines        1315     1310       -5     
  Branches       91       89       -2     
==========================================
- Hits         1148     1147       -1     
+ Misses        124      122       -2     
+ Partials       43       41       -2     
Files with missing lines Coverage Δ
...n/sources/incremental/IncrementalCacheManager.java 88.32% <100.00%> (+4.17%) ⬆️

@ascopes ascopes merged commit cb9f222 into main Dec 22, 2024
13 checks passed
@ascopes ascopes deleted the task/optimise-incremental-cache branch December 22, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general improvements Fixing/updating internal components and code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant