Add configuration option to generate the binary proto descriptor #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascopes
requested changes
Dec 22, 2024
protobuf-maven-plugin/src/it/protoc-descriptor-file/selector.groovy
Outdated
Show resolved
Hide resolved
...en-plugin/src/main/java/io/github/ascopes/protobufmavenplugin/mojo/AbstractGenerateMojo.java
Outdated
Show resolved
Hide resolved
...main/java/io/github/ascopes/protobufmavenplugin/protoc/ProtocArgumentFileBuilderBuilder.java
Outdated
Show resolved
Hide resolved
...-plugin/src/it/protoc-descriptor-file/src/test/java/org/example/helloworld/ProtobufTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/github/ascopes/protobufmavenplugin/generation/ProtobufBuildOrchestrator.java
Outdated
Show resolved
Hide resolved
...plugin/src/main/java/io/github/ascopes/protobufmavenplugin/generation/GenerationRequest.java
Show resolved
Hide resolved
|
In |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 40 40
Lines 1300 1300
Branches 88 88
=======================================
Hits 1138 1138
Misses 121 121
Partials 41 41
|
…mavenplugin/mojo/AbstractGenerateMojo.java Co-authored-by: Ashley <73482956+ascopes@users.noreply.github.com>
ascopes
reviewed
Dec 22, 2024
...en-plugin/src/main/java/io/github/ascopes/protobufmavenplugin/mojo/AbstractGenerateMojo.java
Show resolved
Hide resolved
|
I've just updated the CI pipeline... if you rebase onto the main branch, it should hopefully run the pipeline for you on this PR without me approving it each time first... hopefully. |
ascopes
added a commit
that referenced
this pull request
Jan 7, 2025
Extends GH-506 with support for descriptor configuration parameters that can be passed to protoc. - Add three new options: - outputDescriptorIncludeImports - pass the --include_imports flag to protoc. - outputDescriptorIncludeSourceInfo - pass the --include_source_info flag to protoc. - outputDescriprorRetainOptions - pass the --retain_options flag to protoc. - Moved the documentation for descriptor files to a separate location. - Fixed an edge case where incremental compilation could cause inconsistent descriptor file outputs. Enabling descriptor files will now disable incremental compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ciao,
this PR adds an optional descriptorFile parameter which, if present, indicates the file to which the proto file description is to be saved.
Adds the --descriptor_set_out=FILE option to the protoc command.
Regards,
Luca