Upgrade ESLint #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for ESLint upgrade
sohkai
force-pushed
the
upgrade-eslint
branch
2 times, most recently
from
9c1ae44 to
cef09e2
Compare
| @@ -26,9 +27,10 @@ const UploaderEnhancements = [ | |||
| AscribeBlobUploader, | |||
| AscribeRequestKeyUploader | |||
| ]; | |||
| const Uploader = UploaderEnhancements.reduce((Uploader, Enhancer) => Enhancer(Uploader), ReactS3FineUploader); | |||
| const EnhancedUploader = UploaderEnhancements.reduce((Uploader, Enhancer) => Enhancer(Uploader), | |||
| ReactS3FineUploader); | |||
There was a problem hiding this comment.
This looks weird. Maybe don't use an inline arrow function but one that wraps with {} and has a return value.
There was a problem hiding this comment.
Yeah, agreed; do you think it'd look better on a single line or with the return (either causes a linting error that we'd turn off)?
There was a problem hiding this comment.
Decided to go with:
const EnhancedUploader = UploaderEnhancements.reduce(
(Uploader, Enhancer) => Enhancer(Uploader),
ReactS3FineUploader
);I think that looks better?
|
Apart from the suggestions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the ESLint configuration with mostly cosmetic changes to fix new errors. The
BlocksGroupcomponent was moved out ofBlocksConveyorsince it's gotten large enough to deserve it's own component.