Support "ref:" and "path:" versions in .tool-versions #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change is to support the use of
ref:tag/branch/commitandpath:/local/tool/versiontool versions.Before: 😞
After: 🥳
Implementation notes
The code replicates the
list_plugin_exec_paths()behaviour from.asdf/lib/utils.bashand integrates it into the_plugin_env_bash()version-resolution block.Interesting/controversial decisions
Fixed Makefile target names.
Note the change in test helper also disables shellcheck SC2001 because we're matching the start of the string, which is not possible in a simple substitution.
Test coverage
The new tests cover both version types, with a necessary change to
dummy_bin_path()to match the directory naming that's generated in get_install_path() and reversed in list_installed_versions().Loose ends
Testing with dummy shims?