Fix PDO pgsql for macOS with Homebrew and disable PCRE JIT for M1 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP does not compile on openssl@3. The "brew --prefix openssl" command does not behave as expected. If openssl@1.1 is installed then it will not output anything. If opsenssl@3 is installed then it will output a prefix for openssl@3. This commit uses explicit 1.1 version of OpenSSL. OpenSSL 3 was released to homebrew recently, so users may encounter this issue after upgrading to newest versions.
|
This is just what I needed to get a working build of PHP working via asdf, thanks! |
|
@smorimoto any chance this could be merged? |
|
@hlubek Could you rebase this PR to base branch? |
|
@smorimoto I'll rebase the change and have a look at it 👍 |
|
@smorimoto It should work now, I noticed that the logic for |
|
Any update on when we can see this merged? @smorimoto |
albuquerque53
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Very nice, congratulations for the fix!
@smorimoto could you merge this, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libpqpath configure option for macOS for PDO pgsqlWith these fixes we were able to install PHP 7.4, 8.0 and 8.1 on macOS with Intel (older 10.15) and Apple Silicon (12.2), so it should work for a wider variety of OS versions.