Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch phar.php to disable pcre.jit #123

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

qshanahan-springhealth
Copy link
Contributor

@qshanahan-springhealth qshanahan-springhealth commented May 12, 2022

fixes #122 #120 #102 #94

@qshanahan-springhealth
Copy link
Contributor Author

@smorimoto can you trigger workflows for this PR? i'm curious if it broke anything

@Wirone
Copy link

Wirone commented Jun 14, 2022

The same warnings are for PECL. But I don't know if patching is needed, it can be solved by adding pcre.jit=0 to php.ini (for each installed PHP version). edit: patch is required for installation, PECL can be fixed after that using php.ini.

@qshanahan-springhealth
Copy link
Contributor Author

I'm fairly certain this plugin does not work without this PR. Any chance to get this merged?

@smorimoto smorimoto merged commit 64768dc into asdf-community:master Sep 28, 2022
@qshanahan-springhealth qshanahan-springhealth deleted the patch-1 branch October 13, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

memory error while installing php 8.0.19
3 participants