Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditionally install with old installer #11

Merged
merged 7 commits into from
Aug 13, 2021
Merged

Conversation

crflynn
Copy link
Member

@crflynn crflynn commented Aug 13, 2021

Since the new installer breaks the expected behavior with asdf, we use the old installer (until it's deleted) for versions of poetry prior to 1.2.0. For versions after 1.2.0 we use the new installer, since the old installer won't work with newer versions.

Workaround for #10 on versions prior to 1.2, due to python-poetry/poetry#4199

@crflynn crflynn requested a review from smorimoto August 13, 2021 01:49
@crflynn crflynn requested a review from a team as a code owner August 13, 2021 01:49
@crflynn
Copy link
Member Author

crflynn commented Aug 13, 2021

@smorimoto
Copy link
Member

Ideally, you shouldn't even use the sort command, but honestly, I don't think we need to be that strict these days...

@crflynn crflynn merged commit 53241ce into master Aug 13, 2021
@crflynn crflynn deleted the conditional-install branch August 13, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants