Use new Poetry installer whenever possible #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Although I think we should fix #10 first by setting |
Kurt-von-Laven
force-pushed
the
prefer-new-installer
branch
from
dad0d37
to
4b2fc81
Compare
|
Thank you for fixing #10! I rebased on your fix. |
|
Just need to update the tests from 1.2 to 1.1.7 |
Previously, the new installer hosted at https://install.python-poetry.org was only used for versions of Poetry that require it, namely 1.2+. The official Poetry documentation recommends immediate migration from the old, deprecated, get-poetry.py installer to the new installer. Hence, use the new installer for all versions of Poetry that support it, namely 1.1.7+.
Kurt-von-Laven
force-pushed
the
prefer-new-installer
branch
from
4b2fc81
to
89e3949
Compare
|
Whoops; just pushed take two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19.
Previously, the new installer hosted at https://install.python-poetry.org was only used for versions of Poetry that require it, namely 1.2+. The official Poetry documentation recommends immediate migration from the old, deprecated,
get-poetry.pyinstaller to the new installer. Hence, use the new installer for all versions of Poetry that support it, namely 1.1.7+.See this official Poetry blog post announcing the release of 1.2.0 for additional context.