Feature/autocompletion

[Glitchm]

Thought I'd give #27 a crack.

Based changes off the following documentation: https://python-poetry.org/docs/#enable-tab-completion-for-bash-fish-or-zsh

• Checks if version is greater than 1.2.0. If not, informs the user autocompletion won't be setup
• Checks the users default shell
• Runs through some validation to check if files/references already exist based off the default shell
• If files/references don't exist, run commands and update shell profiles
• If no shell matches are found an else statement informs the user it could not find a match

Full disclosure. I was able to fully test with zsh and worked great. I did try setting my default shell to bash/fish, but came across issues just creating a new terminal session so was unable to test the bash/fish side running asdf install poetry 1.2.2.

I'll try creating a container, installing asdf with bash/fish over the next few days and check the results. But wanted to create this PR as I'm sure the functionality is there and wanted this change to be open for discussion.

[Kurt-von-Laven]

I'm not a maintainer, but this looks great to me and seems like a good idea.

[Kurt-von-Laven]

Multiple instances: consider "bash" --> "Bash" since it's a proper noun.

[Glitchm]

Gone through and replaced any instance of bash or zsh with Bash/Zsh as that appears to be the correct way. From what I could find of fish shell it seems to always appear as lowercase so have left that the way it is.

[Kurt-von-Laven]

Consider "BASH, ZSH or FISH" --> "Bash, zsh, or fish shells" since new developers may not realize what these terms refer to and assume they are acronyms.

[Glitchm]

Taken your comment on board. As a compromise are you happy with Could not detect shells Bash, Zsh or fish? As you pointed out, a new dev may not realise what they are and with shells at the end may think fish shells is one thing.

[Kurt-von-Laven]

Yeah, I find your proposed rewording the clearest.

[Kurt-von-Laven]

Yeah, I find your proposed rewording the clearest.

[Kurt-von-Laven]

Nit: "will" --> "do"

[Glitchm]

Yep. That sounds better to me. Changed.

[Glitchm]

Testing in a container with bash as the default shell it seems the completion works but with some issues. Here are my findings.

Found .bash_completions isn't sourced in the bashrc file by default and I needed to add it which isn't in the poetry instructions. As someone that's been a Zsh user for some time, I don't know if this is the norm or possibly something to do with the fact I was using a container and setup to be barebones. So would be good to get some input on that if anyone knows?

Poetry installs and detects default shell Bash:

Detected default shell Bash
Setting up autocompletion for Bash...

Then source Bash and get the following error:

newuser@98c52707c7b4:/$ bash
bash: /home/newuser/.bash_completion: line 40: syntax error near unexpected token `clear'
bash: /home/newuser/.bash_completion: line 40: `            (cache clear)'

This appears to be a known issue and is fixed, but I'm assuming in the next release: python-poetry/poetry#6577

I run the sed command mentioned in the issue, and although kind of works, found another issue:

sed -i.bk -E 's@ \(([a-z]* [a-z]*)( [a-z]*)?\)@ ("\1\2")@g' ~/.bash_completion
newuser@98c52707c7b4:/$ bash
newuser@98c52707c7b4:/$ poetry bash: _get_comp_words_by_ref: command not found
bash: __ltrim_colon_completions: command not found
bash: _get_comp_words_by_ref: command not found
bash: __ltrim_colon_completions: command not found

about    check    env      init     new      resolve  shell    use
add      clear    export   install  plugins  run      show     version
build    config   help     list     publish  search   source
cache    debug    info     lock     remove   self     update

Which lead me to this issue: python-poetry/poetry#3418
Again. Not sure if this is the norm because this is on a container, but I had to install bash-completion package and after running the sed command worked great. So would be good to know if the bash-completion package is usually installed by default.

But after installing that package, I get the following result:

newuser@0df2d5f7e8b7:/$ sed -i.bk -E 's@ \(([a-z]* [a-z]*)( [a-z]*)?\)@ ("\1\2")@g' ~/.bash_completion
newuser@0df2d5f7e8b7:/$ bash
newuser@0df2d5f7e8b7:/$ poetry
about    cache    config   export   init     lock     publish  run      shell    update
add      check    debug    help     install  new      remove   search   show     use
build    clear    env      info     list     plugins  resolve  self     source   version