Skip to content

Commit

Permalink
default memmap=False
Browse files Browse the repository at this point in the history
  • Loading branch information
zacharyburnett committed Oct 31, 2024
1 parent 7ef0859 commit 29aafc6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions asdf/_asdf.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def __init__(
ignore_version_mismatch=NotSet,
ignore_unrecognized_tag=False,
ignore_implicit_conversion=NotSet,
memmap=True,
memmap=False,
lazy_load=True,
custom_schema=None,
):
Expand Down Expand Up @@ -118,7 +118,7 @@ def __init__(
memmap : bool, optional
When `True`, when reading files, attempt to memmap underlying data
arrays when possible. Defaults to ``True``.
arrays when possible. Defaults to ``False``.
lazy_load : bool, optional
When `True` and the underlying file handle is seekable, data
Expand Down Expand Up @@ -1610,7 +1610,7 @@ def open_asdf(
ignore_version_mismatch=NotSet,
ignore_unrecognized_tag=False,
_force_raw_types=False,
memmap=True,
memmap=False,
lazy_tree=NotSet,
lazy_load=True,
custom_schema=None,
Expand Down Expand Up @@ -1654,7 +1654,7 @@ def open_asdf(
memmap : bool, optional
When `True`, when reading files, attempt to memmap underlying data
arrays when possible. Defaults to ``True``.
arrays when possible. Defaults to ``False``.
lazy_load : bool, optional
When `True` and the underlying file handle is seekable, data
Expand Down
1 change: 1 addition & 0 deletions changes/1801.apichange.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
set ``memmap=False`` by default

0 comments on commit 29aafc6

Please sign in to comment.