-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsonschema 4.18 incompatible with asdf #1485
Comments
Some of the errors above are due to asdf expecting jsonschema to provide draft schemas. Line 184 in d33ca09
The above mentioned PR removed these schemas. jsonschema instead pulls the draft schemas in from the following package: Even after fixing that path issue, errors are still seen:
|
jsonschema 4.18 will introduce changes that are incompatible with asdf. More details can be found in: asdf-format#1485 this commit adds an upper pin to jsoncschema and removes it from the devdeps testing
jsonschema 4.18 will introduce changes that are incompatible with asdf. More details can be found in: asdf-format#1485 this commit adds an upper pin to jsoncschema and removes it from the devdeps testing an issue was created to track removal of the pin: asdf-format#1486
To add urgency to resolving this issue, the latest
The only way to get around this now is to install |
Re: #1485 (comment) Oh no... this might affect Jdaviz (in addition to James Davies). cc @kecnry |
I do those steps and get a strange version of a Jupyter notebook that does not allow me to add or delete cells. It just allows me to run an existing notebook |
@jdavies-st thanks for reporting the work around (it was helpful in getting the issue mostly resolved with @jemorrison). This should be addressed by #1591 |
#1591 has Also, what does this mean? asdf will just bundle an old version of jsonschema forever? |
For asdf 2.15.1, jsonschema 4.17.3 is bundled internally (not part of the public api). The docs have some more details: |
Changes to ref resolution introduced here:
python-jsonschema/jsonschema#1049
are incompatible with asdf uses of jsonschema because of deprecations and apparently further changes.
Ignoring the test failures due to warnings from deprecation of the following:
jsonschema.exceptions.RefResolutionError
jsonschema.validators.RefResolver
Validator.resolver
(by filtering the deprecation warnings) still results in numerous test failures.
The text was updated successfully, but these errors were encountered: