Move built-in tags to converters (except ndarray and integer) #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslavich
force-pushed
the
eslavich-move-types-to-converters
branch
from
f62ea56 to
c019ef0
Compare
braingram
requested changes
Mar 16, 2023
There was a problem hiding this comment.
Thanks for taking this on!
I added a bunch of questions. My main concerns are over compatibility and API consistency. Functionally things look good (except for maybe complex which looks... complex) but I'd like more information on some of the test removals and compatibility issues.
braingram
requested changes
Apr 3, 2023
There was a problem hiding this comment.
Thanks for updating this and apologies again for not seeing the update.
I added a few more requests:
- adding a comment to describe the
MIN_VERSION_1_0_0_STANDARDaddition - possibly switching complex types back to using
iter_subclasses
Otherwise the comments are mostly questions to make sure I'm understanding the changes.
Feel free to mark me again for a review request when this is ready for another look.
for more information, see https://pre-commit.ci
…rite the 1.0.0 standard
Co-authored-by: Brett Graham <brettgraham@gmail.com>
eslavich
force-pushed
the
eslavich-move-types-to-converters
branch
from
b722405 to
ede2d03
Compare
eslavich
force-pushed
the
eslavich-move-types-to-converters
branch
from
8201ed1 to
e02d517
Compare
for more information, see https://pre-commit.ci
braingram
approved these changes
Apr 17, 2023
braingram
added a commit
to braingram/asdf
that referenced
this pull request
Aug 1, 2023
that test was removed from main asdf-format#1474 However, that PR contains additional changes that we probably don't want to backport at this time.
Merged
braingram
added a commit
to braingram/asdf
that referenced
this pull request
Aug 1, 2023
that test was removed from main asdf-format#1474 However, that PR contains additional changes that we probably don't want to backport at this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the following built-in tags to converters: