-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update actions to use node16 #488
Conversation
@jimmidyson could you attempt to re-run the latest build on actions? it looks like the runner could temporarily not reach github. If this fixes the build maybe this PR can be merged and released. |
I don't have any way to re-run the actions I'm afraid - would need a maintainer to do so I guess. |
Thank you! Maybe @jthegedus can help us out here? 👀 |
Hey crew, I am looking into this now. Apologies for the delay, though the changes here were small, the diff was large and so kept getting pushed back on my todo list. I will try and resolve this CI issue and merge. I realise this repo has been neglected, I intend to take ownership of this within the core team and get some of these other open feature requests closed as well as modernize the repo itself. I appreciate the time you all have taken to contribute these changes 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty, this looks good to me.
The resource which guided me towards the fix was adaptlearning/adapt_authoring#1431
As far as releasing this specific change goes, I want to re-jig the GitHub Releases to follow the automation we have in our other repos, so until a tagged version becomes available I will ask you all to use the commit reference style:
steps:
- name: asdf_install
uses: asdf-vm/actions/install@6844d09
# Reference a specific commit (most strict)
Where the SHA is the commit from master
after the merge.
NOTE: an update to the min version of Node is considered a breaking API change to the Action, so this will release under tag 2.x
Interesting that the git URL didn't work, thanks for fixing it and getting this merged! |
Co-authored-by: James Hegedus <jthegedus@hey.com> Fixes asdf-vm#484
https://github.com/asdf-vm/actions/releases/tag/v2.0.0 Currently only supports full semver version:
Please test and report issues! |
See
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
for more details.- feat: Update actions to use node16
Fixes #484.