Check signatures/checksums to ensure authenticity #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypid
force-pushed
the
feature/check_openpgp_signatures
branch
2 times, most recently
from
8f834c1 to
2e79e06
Compare
This was referenced Feb 13, 2017
Merged
|
Test failing reason: #24 not merged |
|
@ypid I just read a few comments on one of the linked nvm issues. Thank you very much for this PR ~! |
Please refer to [Verifying Node.js Binaries](https://blog.continuation.io/verifying-node-js-binaries/) for why this is important. Related to: asdf-vm/asdf#158 Mitigates: nodejs/node#9859 Mitigates: nodejs/node#6821 Implementing this feature required some rework of the `install` script which is included in this PR. The following other PR are superseded/included in this one: Closes: asdf-vm#15 Closes: asdf-vm#16 Closes: asdf-vm#19 Note that this PR also updates the base download URL from "http://nodejs.org/dist" to "https://nodejs.org/dist" meaning that before this PR (or asdf-vm#16 which is not merged), binaries where downloaded over plain legacy HTTP! (those binaries where later executed by the user). This is really bad and is fairly easy to exploit! Related to: nvm-sh/nvm#736 Related to: nvm-sh/nvm#793
Related to: asdf-vm/asdf#161
ypid
force-pushed
the
feature/check_openpgp_signatures
branch
from
cea3960 to
dc758c1
Compare
This was referenced Feb 20, 2017
Closed
ypid
force-pushed
the
feature/check_openpgp_signatures
branch
from
dc758c1 to
63db65e
Compare
|
Thanks for merging #24. Rerun test and passing now. |
ypid
force-pushed
the
feature/check_openpgp_signatures
branch
from
63db65e to
001999f
Compare
ypid
added a commit
to ypid/asdf-nodejs
that referenced
this pull request
Feb 20, 2017
ypid
added a commit
to ypid/asdf
that referenced
this pull request
Feb 20, 2017
As the proposal for asdf-nodejs to [validate OpenPGP signatures](asdf-vm/asdf-nodejs#25) has been approved and merged I guess the design is sound and other plugins can follow. Related to: asdf-vm#159
rajr5
pushed a commit
to rajr5/asdf
that referenced
this pull request
Jun 23, 2023
As the proposal for asdf-nodejs to [validate OpenPGP signatures](asdf-vm/asdf-nodejs#25) has been approved and merged I guess the design is sound and other plugins can follow. Related to: #159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to Verifying Node.js Binaries for why this is important.
Related to: asdf-vm/asdf#158
Mitigates: nodejs/node#9859
Mitigates: nodejs/node#6821
Implementing this feature required some rework of the
installscript which is included in this PR. The following other PR are superseded/included in this one:Closes: #15
Closes: #16(Merged directly as it is high priority, this PR has been rebased on top of #16)Closes: #19
Note that this PR also updates the base download URL from "http://nodejs.org/dist" to "https://nodejs.org/dist" meaning that before this PR (or #16), binaries where downloaded over plain legacy HTTP! (those binaries where later executed by the user). This is really bad and is fairly easy to exploit!
Related to: nvm-sh/nvm#736
Related to: nvm-sh/nvm#793