Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set proper ShellCheck source for utils.bash #75

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

ivanvc
Copy link
Contributor

@ivanvc ivanvc commented Jul 5, 2023

The ShellCheck directive currently points to ../lib/utils.bash. However, this raises an info log, as ShellCheck is not able to open the file. As the linter runs from the top level of the repository, the right path should be ./lib/utils.bash.

In bin/install line 9:
source "${plugin_dir}/lib/utils.bash"
       ^----------------------------^ SC1091 (info): Not following: ../lib/utils.bash: openBinaryFile: does not exist (No such file or directory)

The ShellCheck directive currently points to `../lib/utils.bash`.
However, this raises an info log, as ShellCheck is not able to open the
file. As the linter runs from the top level of the repository, the right
path should be `./lib/utils.bash`.

In bin/install line 9:
source "${plugin_dir}/lib/utils.bash"
       ^----------------------------^ SC1091 (info): Not following:
       ../lib/utils.bash: openBinaryFile: does not exist (No such file
       or directory)
axilleas added a commit to axilleas/asdf-minify that referenced this pull request Jul 6, 2023
Copy link
Collaborator

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, of course, good catch! Thanks 🙇‍♂️

@jthegedus jthegedus merged commit 24a53fb into asdf-vm:main Jul 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants