Add support for a default-gems file #35
Merged
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoa
commented
Apr 24, 2017
| if gem install $name > /dev/null 2>&1; then | ||
| echo "SUCCESS" | ||
| else | ||
| echo "FAIL" |
There was a problem hiding this comment.
Perhaps we could print the whole error message here? Or is this OK? If so, I guess the user can retry the command manually. Also, I'm not sure if we should exit 1 if at least one of the gems fails to install.
The README example would print out the following (supposing "pry" installation fails):
Installing bundler gem.... SUCCESS
Installing pry gem... FAIL
Installing gem-ctags... SUCCESS
|
Thanks! This is perfect. |
grepsedawk
added a commit
to grepsedawk/asdf-nodejs
that referenced
this pull request
Jul 31, 2017
grepsedawk
added a commit
to grepsedawk/asdf-nodejs
that referenced
this pull request
Jul 31, 2017
Partial Credit: asdf-vm/asdf-ruby#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31