-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement var substitution feature #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 91.27% 91.60% +0.32%
==========================================
Files 6 6
Lines 871 905 +34
==========================================
+ Hits 795 829 +34
Misses 62 62
Partials 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mikerott
force-pushed
the
feature/var-substitution
branch
from
April 28, 2023 14:46
132f813
to
9b9b7fd
Compare
mikerott
force-pushed
the
feature/var-substitution
branch
from
April 28, 2023 15:00
9b9b7fd
to
f008036
Compare
mikerott
changed the title
implement var substituion feature
implement var substitution feature
Apr 28, 2023
dkolbly
reviewed
Apr 28, 2023
dontfollowsean
approved these changes
May 1, 2023
FloopySaucer
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README already implied that the feature this PR introduces was a thing. It was not, but after this PR, it is! Consider this PR a proposal for a feature, and because I did not add feature-specific function names to the SDK, this PR represents a breaking change and will require a major version update. That said, I expect that no one will actually be broken upon updating.
Below was my original review request and is now outdated.
All backward compatibility remains intact, so this will be a minor version update.
I have a specific review question. This PR, as it is, behaves such that if a substitution is desired, but implemented incorrectly, the result is to return
nil, false
(nil value, not found) rather than the unsubstituted value.For example, imagine the env vars are:
and the YAML file is:
The SDK could behave such that "find
B
" returnsnil, false
or it returns"${C}", true
. I think I prefer the former, as it's the earliest warning sign to the user of this lib that they're seeking a key (C
) that does not exist.