build_execution_plan() tripping over same name lamina #52
Assignees
Labels
bug
Something isn't working
Comments
|
looks like the issue begins with find_laminae() inside of build_execution_plan() |
asenetcky
added a commit
that referenced
this issue
Dec 22, 2024
* fix #52 * Style code (GHA) * Increment version number to 1.2.1 --------- Co-authored-by: asenetcky <asenetcky@users.noreply.github.com>
|
queued up for release |
asenetcky
added a commit
that referenced
this issue
Dec 24, 2024
## features: - implemented `adhoc()` to run portions of strata project by name, users no longer need to have or remember paths - most functions will now only work inside of a strata project - functions now more consistant with handling input and will provide more helpful error messages to the user - code more tightly organized, added adhoc family ## bug fixes: - fix #52: build_execution_plan() mishandled same-name laminae across multiple strata. Would attribute script paths in one, to both. Now strata can consistantly differentiate between laminae of the same name. ## miscellaneous: - rename parse_log to survey_log - closes #43 - better argument input checking from users - path checking - check if project/folder is a strata project - updating error handling - replacing stops with rlang::abort - replace log errors (where appropriate) with rlang::abort --------- Co-authored-by: asenetcky <asenetcky@users.noreply.github.com>
asenetcky
added a commit
that referenced
this issue
Feb 3, 2025
# strata 1.4.0 This release is all about bug fixes and improvements to the user experience. ## Breaking Changes * Added dependency for R >= 4.1.0 due to use of base R pipe `|>`. ## New features * `adhoc()` added to allow users to ad hoc a portion of their strata project by name (instead of having to remember all the different file paths) (#46). * `survey_log()` added to allow users to survey the logs in their strata project as a dataframe (#41, #43). * Added stricter strata project checking (#48). * added stricter path checking for functions that require paths to existing files and folders. * added more helpful error messages for users regarding paths, * Functions will now check if a folder is a strata project or not and provide helpful error messages if they are not strata projects. ## Fixes * File name/path cleaning performed by strata to ensure valid path names will will now stop blocking certain path/name manipulations. * `adhoc_stratum()` will now properly handle existing file paths and avoid errors stating otherwise (#44). * `build_execution_plan()` now properly handles the case where a laminae from different strata have the same name (#52). * The timestamp in the `log_*()` family of functions will now always be 24 characters long (#40). * `build_outlined_strata_project()` will now allow for multiple laminae per stratum (#36). ## Minor Improvements * File name/path cleaning performed by strata to ensure valid path names will now ignore dashes "-" in file names. * `adhoc_*()` functions will now "fail fast", stop execution and alert users of problems (#45). --------- Co-authored-by: asenetcky <asenetcky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
laminae names should be unique, but it's not enforced and it cannot always be expected.
given a project with 2 strata (stratum 1, stratum2) and both have a lamina1, with code identically named scripts, I noticed the that the execution plan would attribute the stratum name and lamina name to the wrong code path.
The text was updated successfully, but these errors were encountered: