Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add context to check response #101

Merged
merged 6 commits into from
Sep 14, 2024
Merged

add context to check response #101

merged 6 commits into from
Sep 14, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Sep 11, 2024

@coveralls
Copy link

coveralls commented Sep 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10864344989

Details

  • 0 of 45 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 24.522%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ds/check.go 0 20 0.0%
pkg/directory/v3/reader.go 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/directory/v3/reader.go 1 12.73%
Totals Coverage Status
Change from base Build 10686443057: -0.3%
Covered Lines: 859
Relevant Lines: 3503
💛 - Coveralls

@gertd gertd mentioned this pull request Sep 11, 2024
Merged
ronenh
ronenh approved these changes Sep 12, 2024
View reviewed changes
pkg/ds/check.go Outdated Show resolved Hide resolved
pkg/ds/check.go Outdated Show resolved Hide resolved
@gertd gertd merged commit 6a6385b into main Sep 14, 2024
2 checks passed
@gertd gertd deleted the check-reason branch September 14, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh ronenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gertd @coveralls @ronenh