This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Quick-reply buttons for schedule/attendance #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditsuke
reviewed
Sep 27, 2023
ditsuke
reviewed
Sep 30, 2023
AnshGupta01
changed the title
Modified for Draft PR (The Attendance buttons are not rendering).
The attendance reply buttons are functioning properly. #47
Oct 1, 2023
ditsuke
suggested changes
Oct 1, 2023
src/states/state-handlers.ts
Outdated
@@ -228,6 +246,67 @@ export const handleLoggedIn = async (ctx: BotHandlerContext): Promise<User> => { | |||
return updatedUser; | |||
}; | |||
|
|||
export const handleReplyAttendanceButton = async (ctx: BotHandlerContext): Promise<User> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to handleQuickAttendanceButtons
, or something else that's descriptive.
Final Changes are submitted! |
ditsuke
changed the title
The attendance reply buttons are functioning properly. #47
feat: Quick-reply buttons for schedule/attendance
Oct 1, 2023
vinayaknayar
reviewed
Oct 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bot works as expected. But the formatting changes like here changes the git history.
Yes yes, Tushar and me were fixing some eslint errors as well! |
ditsuke
approved these changes
Oct 2, 2023
vinayaknayar
approved these changes
Oct 11, 2023
Cheers @AnshGupta01. Feature should be live as soon as CI is done deploying 🎉 |
:) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47