Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

feat: Quick-reply buttons for schedule/attendance #49

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

AnshGupta01
Copy link
Contributor

@AnshGupta01 AnshGupta01 commented Sep 27, 2023

Fixes #47

src/states/state-handlers.ts Outdated Show resolved Hide resolved
src/states/state-handlers.ts Outdated Show resolved Hide resolved
src/states/state-handlers.ts Outdated Show resolved Hide resolved
@AnshGupta01 AnshGupta01 changed the title Modified for Draft PR (The Attendance buttons are not rendering). The attendance reply buttons are functioning properly. #47 Oct 1, 2023
@AnshGupta01 AnshGupta01 marked this pull request as ready for review October 1, 2023 05:18
src/states/render-messages.ts Outdated Show resolved Hide resolved
@@ -228,6 +246,67 @@ export const handleLoggedIn = async (ctx: BotHandlerContext): Promise<User> => {
return updatedUser;
};

export const handleReplyAttendanceButton = async (ctx: BotHandlerContext): Promise<User> => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to handleQuickAttendanceButtons, or something else that's descriptive.

@AnshGupta01
Copy link
Contributor Author

Final Changes are submitted!

@ditsuke ditsuke changed the title The attendance reply buttons are functioning properly. #47 feat: Quick-reply buttons for schedule/attendance Oct 1, 2023
@ditsuke ditsuke requested a review from vinayaknayar October 1, 2023 07:17
Copy link
Member

@vinayaknayar vinayaknayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot works as expected. But the formatting changes like here changes the git history.

@AnshGupta01
Copy link
Contributor Author

The bot works as expected. But the formatting changes like here changes the git history.

Yes yes, Tushar and me were fixing some eslint errors as well!

@ditsuke ditsuke merged commit b524707 into asetalias:main Oct 11, 2023
@ditsuke
Copy link
Member

ditsuke commented Oct 11, 2023

Cheers @AnshGupta01. Feature should be live as soon as CI is done deploying 🎉

@AnshGupta01
Copy link
Contributor Author

:)

@AnshGupta01 AnshGupta01 deleted the ASoC branch October 11, 2023 15:57
@AnshGupta01 AnshGupta01 restored the ASoC branch October 11, 2023 15:57
@AnshGupta01 AnshGupta01 deleted the ASoC branch October 11, 2023 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional buttons to check attendance+schedule for the current/previous day
3 participants