Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on multiple node versions in travis #35

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

sudo-suhas
Copy link
Collaborator

The tests can run in parallel and the module can be used with confidence on the tested node versions.

@asfktz
Copy link
Owner

asfktz commented Jul 7, 2017

Waited for you to put your hands of that file 😉

I'm new to CI, so feel free to change it however you believe is necessary.

@asfktz asfktz merged commit 259eab5 into asfktz:master Jul 7, 2017
@sudo-suhas sudo-suhas deleted the ci_multi_node_ver branch July 7, 2017 12:25
@sudo-suhas
Copy link
Collaborator Author

Waited for you to put your hands of that file 😉

Ha ha.. too much.

Here is a sample .travis.yml file - https://github.com/sudo-suhas/elastic-builder/blob/master/.travis.yml

I dunno how good it is though.. I started working on open source recently too.
Couple of things we can do:

  • Cache node_modules. This can improve build times
  • Add rule to not test branches created by npm version or yarn version.

As of now you are not using greenkeeper or a hosted service for coverage. While greenkeeper might be overkill right now, I can highly recommend https://coveralls.io/.

Let's discuss here before I make the PR for travis config change.

@sudo-suhas
Copy link
Collaborator Author

Actually none of these changes are needed per se. The current one will serve the purpose just fine.

@asfktz
Copy link
Owner

asfktz commented Jul 7, 2017

Yeah, I guess time will tell us what we need (:

@asfktz asfktz added this to the 0.1.0 milestone Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants