Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auxiliary column support #123

Merged
merged 37 commits into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
776d86c
initial pass at PARTITION KEY support.
asg017 Oct 14, 2024
8a7bde9
Initial pass, allow auxiliary columns on vec0 virtual tables
asg017 Oct 14, 2024
bfb279c
update TODO
asg017 Oct 14, 2024
f36d4a0
unit tests
asg017 Nov 5, 2024
84d6a14
gha this PR branch
asg017 Nov 13, 2024
c7bcf58
fixup tests
asg017 Nov 13, 2024
4cb891a
doc internal
asg017 Nov 13, 2024
8369dfe
fix tests, KNN/rowids in
asg017 Nov 13, 2024
1a21336
define SQLITE_INDEX_CONSTRAINT_OFFSET
asg017 Nov 13, 2024
26fbdf2
whoops
asg017 Nov 13, 2024
76b8247
update tests, syrupy, use uv
asg017 Nov 13, 2024
99095c7
un ignore pyproject.toml
asg017 Nov 13, 2024
5d571eb
dot
asg017 Nov 13, 2024
5949209
tests/
asg017 Nov 13, 2024
3c1fb0a
type error?
asg017 Nov 13, 2024
78717dd
win: .exe, update error name
asg017 Nov 13, 2024
f3d4bb3
try fix macos python, paren around expr?
asg017 Nov 13, 2024
afb3826
win bash?
asg017 Nov 13, 2024
c6df446
dbg :(
asg017 Nov 13, 2024
8149761
explicit error
asg017 Nov 13, 2024
93b3433
op
asg017 Nov 13, 2024
0bd9fc5
dbg win
asg017 Nov 13, 2024
21b11e1
win ./tests/.venv/Scripts/python.exe
asg017 Nov 13, 2024
03f29d5
block UPDATEs on partition key values for now
asg017 Nov 13, 2024
f00aa68
Merge branch 'main' into partition-by
asg017 Nov 13, 2024
0eece06
Merge branch 'partition-by' into auxiliary
asg017 Nov 13, 2024
afbcbb7
test this branch
asg017 Nov 13, 2024
da14fa1
accidentally removved "partition key type mistmatch" block during merge
asg017 Nov 13, 2024
70c9c17
typo ugh
asg017 Nov 13, 2024
93218e4
bruv
asg017 Nov 13, 2024
163654b
start aux snapshots
asg017 Nov 13, 2024
d6adbc9
drop aux shadow table on destroy
asg017 Nov 13, 2024
7d4c023
enforce column types
asg017 Nov 13, 2024
743511a
block WHERE constraints on auxiliary columns in KNN queries
asg017 Nov 13, 2024
a394c5f
support delete
asg017 Nov 13, 2024
5d9b923
support UPDATE on auxiliary columns
asg017 Nov 13, 2024
7832a7f
Merge branch 'main' into auxiliary
asg017 Nov 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
branches:
- main
- partition-by
- auxiliary
permissions:
contents: read
jobs:
Expand Down
8 changes: 8 additions & 0 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,11 @@
- [ ] UPDATE on partition key values
- remove previous row from chunk, insert into new one?
- [ ] properly sqlite3_vtab_nochange / sqlite3_value_nochange handling

# auxiliary columns

- later:
- NOT NULL?
- perf: INSERT stmt should be cached on vec0_vtab
- perf: LEFT JOIN aux table to rowids query in vec0_cursor for rowid/point
stmts, to avoid N lookup queries
Loading
Loading