Ensure GithubPackageReleaseAssetsTest integration test uses GH token …

…for API call
asgrim · Jan 3, 2025 · 7a21166 · 7a21166
1 parent 2a191c2
commit 7a21166
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -29,6 +29,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - uses: actions/checkout@v4
+      - run: composer config --global github-oauth.github.com ${{ secrets.GITHUB_TOKEN }}
       # temporarily remove Psalm until ready for PHP 8.4
       - name: remove psalm
         if: matrix.php-versions == '8.4'

diff --git a/src/Downloading/GithubPackageReleaseAssets.php b/src/Downloading/GithubPackageReleaseAssets.php
@@ -77,7 +77,7 @@ private function getReleaseAssetsForPackage(
         Assert::notNull($package->downloadUrl);
 
         try {
-            $decodedRepsonse = $httpDownloader->get(
+            $r = $httpDownloader->get(
                 $this->githubApiBaseUrl . '/repos/' . $package->githubOrgAndRepository() . '/releases/tags/' . $package->version,
                 [
                     'retry-auth-failure' => false,
@@ -86,7 +86,9 @@ private function getReleaseAssetsForPackage(
                         'header' => $authHelper->addAuthenticationHeader([], $this->githubApiBaseUrl, $package->downloadUrl),
                     ],
                 ],
-            )->decodeJson();
+            );
+            var_dump($r->getHeaders());
+            $decodedRepsonse = $r->decodeJson();
         } catch (TransportException $t) {
             /** @link https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#get-a-release-by-tag-name */
             if ($t->getStatusCode() === 404) {

diff --git a/test/integration/Downloading/GithubPackageReleaseAssetsTest.php b/test/integration/Downloading/GithubPackageReleaseAssetsTest.php
@@ -5,6 +5,8 @@
 namespace Php\PieIntegrationTest\Downloading;
 
 use Composer\Config;
+use Composer\Factory;
+use Composer\IO\BufferIO;
 use Composer\IO\IOInterface;
 use Composer\Package\CompletePackage;
 use Composer\Util\AuthHelper;
@@ -59,7 +61,13 @@ public function testDeterminingReleaseAssetUrlForWindows(): void
             99,
         );
 
-        $io     = $this->createMock(IOInterface::class);
+        $io = $this->createMock(IOInterface::class);
+        if (getenv('GITHUB_TOKEN')) {
+            $io->method('hasAuthentication')
+                ->willReturn(true);
+            $io->method('getAuthentication')
+                ->willReturn(['username' => getenv('GITHUB_TOKEN'), 'password' => 'x-oauth-basic']);
+        }
         $config = new Config();
 
         self::assertSame(