Update exchangerate.host driver to match new API #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exchangerate.hostAPI service was recently updated (seemingly without warning) and put behind a paywall. As part of the updates, all requests now require an API key to be passed as a query parameter. The endpoints, accepted query parameters, and response structure have also all been updated.This PR makes some updates to the package so that we can interact with the newer version of this API.
Breaking change?
I'm not entirely sure whether this is a breaking change or not 🤔
This change will require human intervention (adding the API key to the
.envfile) which leads me to think it'd be a major version bump.However, this fix is needed due to an external change and anyone using this package won't be able to interact with this API at the moment. So I think this means it can be treated as a bug fix (patch version bump) rather than a breaking change (major version bump).