Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "driver" functionality #84

Merged
merged 16 commits into from
Jan 29, 2023
Merged

Add "driver" functionality #84

merged 16 commits into from
Jan 29, 2023

Conversation

ash-jc-allen
Copy link
Owner

This PR aims to decouple the package from the exchangeratesapi.io API. This API has been bought by API Layer, and they're pushing users over to the newer version of the API which works slightly differently.

So I'm adding "drivers" and using the manager pattern so that we can add a driver for the existing API and a driver for the new API.

The benefit of doing this is that we can also support more APIs in the future by adding new drivers.

@ash-jc-allen ash-jc-allen changed the base branch from master to v6.0 January 28, 2023 20:16
@ash-jc-allen ash-jc-allen marked this pull request as ready for review January 29, 2023 00:32
@ash-jc-allen ash-jc-allen merged commit c2deae5 into v6.0 Jan 29, 2023
@ash-jc-allen ash-jc-allen deleted the feature/newer-api branch January 29, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants