Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tags #39

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Updated tags #39

merged 1 commit into from
Mar 5, 2020

Conversation

innoflash
Copy link
Contributor

Currently if you run php artisan vendor:publish the package configs are marked as a generic config.

Screenshot from 2020-03-04 22-25-18

God knows how many packages are tagged like this but after this PR the publish command is specific onto which package you are publishing

Screenshot from 2020-03-05 10-12-30

@innoflash innoflash marked this pull request as ready for review March 5, 2020 08:16
@ash-jc-allen
Copy link
Owner

@innoflash Great spot! Thanks for chaning this, I'll pull it in now 😄

@ash-jc-allen ash-jc-allen merged commit 371110c into ash-jc-allen:master Mar 5, 2020
@innoflash innoflash deleted the update-config branch March 5, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@innoflash @ash-jc-allen