Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to forward query parameters from source to destination #94

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

julienarcin
Copy link
Contributor

Referencing discussion #93

@ash-jc-allen
Copy link
Owner

Hey @julienarcin! Thanks for the PR, I'll take a look at this later today 😄

@ash-jc-allen ash-jc-allen merged commit 4a8118d into ash-jc-allen:v6.0.0 Oct 21, 2021
@ash-jc-allen
Copy link
Owner

I've looked through this PR and made some slight changes to it to simplify it a bit. Instead of the params overriding each other, they'll just be appended to the end of the URL instead.

Example:
URL: https://short.com/short/ABC123
Destination URL: https://destination.com?param1=hello&param2=goodbye

Request to: https://short.com/short/ABC123?param1=abc will redirect to: https://destination.com?param1=hello&param2=goodbye&param1=abc.

Huge thanks for the PR, I think this'll come in handy for quite a few people! 😄

@julienarcin
Copy link
Contributor Author

Thanks 😉

@julienarcin
Copy link
Contributor Author

Maybe you should update the readme.md file to reflect the change ?

@ash-jc-allen
Copy link
Owner

@julienarcin Don't worry, I'm just working on that now and making a few changes at once :)

@julienarcin
Copy link
Contributor Author

OK 👍

@julienarcin julienarcin deleted the v6.0.0 branch October 23, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants