chore: use a better config name

ash-project · Sep 4, 2024 · a2cfaa5 · a2cfaa5
1 parent 06cd509
commit a2cfaa5
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/config/config.exs b/config/config.exs
@@ -29,7 +29,7 @@ if Mix.env() == :test do
     Ash.Test.Support.PolicySimple.Domain
   ]
 
-  config :ash, :policy, forbid_static_forbidden_reads?: false
+  config :ash, :policy, no_filter_static_forbidden_reads?: false
 
   config :ash, :custom_expressions, [Ash.Test.Expressions.JaroDistance]
 

diff --git a/documentation/tutorials/get-started.md b/documentation/tutorials/get-started.md
@@ -258,7 +258,7 @@ config :ash,
   default_page_type: :keyset
 
 config :ash, :policies,
-  forbid_static_forbidden_reads?: false
+  no_filter_static_forbidden_reads?: false
 ```
 
 ### Try our first resource out

diff --git a/lib/ash/policy/authorizer/authorizer.ex b/lib/ash/policy/authorizer/authorizer.ex
@@ -1557,14 +1557,15 @@ defmodule Ash.Policy.Authorizer do
   end
 
   defp forbidden_due_to_strict_policy?(authorizer) do
-    forbid_static_forbidden_reads? =
+    no_filter_static_forbidden_reads? =
       Keyword.get(
         Application.get_env(:ash, :policy, []),
-        :forbid_static_forbidden_reads?,
+        :no_filter_static_forbidden_reads?,
         true
       )
 
-    if forbid_static_forbidden_reads? || authorizer.for_fields || authorizer.action.type != :read do
+    if no_filter_static_forbidden_reads? || authorizer.for_fields ||
+         authorizer.action.type != :read do
       true
     else
       authorizer.policies

diff --git a/lib/ash/policy/filter_check.ex b/lib/ash/policy/filter_check.ex
@@ -83,14 +83,14 @@ defmodule Ash.Policy.FilterCheck do
         |> filter(authorizer, opts)
         |> Ash.Expr.fill_template(actor, Ash.Policy.FilterCheck.args(authorizer), context)
         |> then(fn expr ->
-          forbid_static_forbidden_reads? =
+          no_filter_static_forbidden_reads? =
             Keyword.get(
               Application.get_env(:ash, :policy, []),
-              :forbid_static_forbidden_reads?,
+              :no_filter_static_forbidden_reads?,
               true
             )
 
-          if forbid_static_forbidden_reads? || authorizer.for_fields ||
+          if no_filter_static_forbidden_reads? || authorizer.for_fields ||
                authorizer.action.type != :read ||
                context[:private][:pre_flight_authorization?] do
             try_eval(expr, authorizer)

diff --git a/lib/mix/tasks/install/ash.install.ex b/lib/mix/tasks/install/ash.install.ex
@@ -68,7 +68,7 @@ defmodule Mix.Tasks.Ash.Install do
     |> Igniter.Project.Config.configure(
       "config.exs",
       :ash,
-      [:policies, :forbid_static_forbidden_reads?],
+      [:policies, :no_filter_static_forbidden_reads?],
       false
     )
     |> then(fn igniter ->