fix: allow for a custom json_processor #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- compatilbe with LangChain.MessageProcessors
Contributor
Author
|
I have tested this with a custom json processor I wrote. |
zachdaniel
reviewed
Jun 28, 2025
| - `:max_retries` - Maximum number of retry attempts for invalid JSON (default: 3) | ||
| - `:json_format` - Format to request JSON in (:markdown, :xml) (default: :markdown) | ||
| - `:json_processor` - Custom JSON processor function compatible with `JsonProcessor.new` type. |
Contributor
There was a problem hiding this comment.
I would leave out this firs line. Also, we should have these types properly link to the docs in LangChain. You can run mix docs locally to see that . Use things like t:LangChain.Something.message_processor(). Then , you don't have to copy the type here, because they will see the type on hover etc.
Contributor
Author
There was a problem hiding this comment.
Arrey.
Good idea! Will do that.
zachdaniel
approved these changes
Jun 29, 2025
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RequestJson adapter, currently, the JsonProcesser is used (default) as given by the LangChain lib.
allow passing a custom json processor.
Contributor checklist
Leave anything that you believe does not apply unchecked.