fix: don't deduplicate argument types by argument name #162
Conversation
As mentioned in the upgrade guide, the point of dropping auto generation of types was avoiding conflicts when two arguments had the same name but different types. Now that we require explicit generation, we can actually support that usecase for, e.g., arguments with the same name but different types in create/update mutations.
|
Drafted to check if we have to deduplicate for type instead, now that we removed deduplication for name |
|
Looks great! Merge when ready 😁 |
|
Oh, interesting...I think we deduplicate in type name somewhere already? There are definitely already cases where people reuse the same enum/new type and it doesn't cause issues. |
|
I'm hitting this: if I define a NewType with both I'm checking to see if I can reproduce this in a test case. |
|
So the duplication thing is actually orthogonal to this (I'm opening an issue about it), so this can be merged |
|
🚀 Thank you for your contribution! 🚀 |
As mentioned in the upgrade guide, the point of dropping auto generation of types was to avoid conflicts when two arguments had the same name but different types. Now that we require explicit generation, we can actually support that usecase for, e.g., arguments with the same name but different types in create/update mutations.
Contributor checklist