Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more sort order values #91

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat: add more sort order values #91

merged 3 commits into from
Aug 28, 2023

Conversation

barnabasJ
Copy link
Contributor

No description provided.

@barnabasJ barnabasJ self-assigned this Aug 28, 2023
@barnabasJ barnabasJ added the enhancement New feature or request label Aug 28, 2023
@zachdaniel
Copy link
Contributor

I like this, but I think we might want to expose it as NULL instead of NIL in the graphql layer.

zachdaniel
zachdaniel reviewed Aug 28, 2023
View reviewed changes
lib/api/api.ex Outdated Show resolved Hide resolved
@zachdaniel zachdaniel merged commit bce89e9 into main Aug 28, 2023
11 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@barnabasJ barnabasJ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barnabasJ @zachdaniel