-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generator: Do not generate code for "disabled" extensions #448
Conversation
e028ca2
to
90e3dac
Compare
Whoops, should have ran We should either:
|
74a9cf5
to
e660827
Compare
261d91b
to
c867654
Compare
c867654
to
86fdd4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some unrelated updates got mixed in?
It is unlikely that disabled, reserved extensions (without naming whatsoever) are used through Ash bindings generated from Vulkan-Headers releases, and are best ignored to reduce diff noise and spurious issues [1] with unfinished extension definitions. This approach matches what is defined in the registry spec for `supported="disabled"` [2]: use `supported="disabled"` to indicate this extension should never be processed. [1]: KhronosGroup/Vulkan-Docs#1549 [2]: https://github.com/KhronosGroup/Vulkan-Docs/blob/b4e8cd820b2487bc892b391fb26b49501473a6a6/registry.txt#L1302-L1306
86fdd4c
to
4cd49a1
Compare
Looks like I either forgot to re-sync the submodule to EDIT: And in the force-push I forgot to update the readme yet again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
It is unlikely that disabled, reserved extensions (without naming whatsoever) are used through Ash bindings generated from Vulkan-Headers releases, and are best ignored to reduce diff noise and spurious issues 1 with unfinished extension definitions.
This approach matches what is defined in the registry spec for
supported="disabled"
2:Let me know if someone is using our bindings to access in-development extensions through these means though! (But in that case I expect a local substitution in
vk.xml
+ regeneration...)