Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vulkan-Headers to 1.2.191; drop Video enum-variant edgecases #463

Merged
merged 8 commits into from
Sep 8, 2021

Conversation

MarijnS95
Copy link
Collaborator

Not creating a patch release for this because the changes are limited to the provisional video extension, and breaking changes at that. This should normally require a minor release as we haven't even been able to hide these behind a feature toggle yet :/

If the next updates/PRs are interesting, should we go and push a patch release anyway at risk of breaking someones experimental workflow for a bit?

@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.2.187; drop Video enum-variant edgecases Update Vulkan-Headers to 1.2.188; drop Video enum-variant edgecases Aug 10, 2021
@MarijnS95
Copy link
Collaborator Author

The last commit is now replicating #352, without refactoring type handling in the generator. This is necessary because vk.xml in 1.2.188 changed once again how pVersionData is represented; that's the only field across the entire API with a pointer to a static-sized array (instead of a dynamic-sized slice with a latexmath: expression based on other variables).

@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.2.188; drop Video enum-variant edgecases Update Vulkan-Headers to 1.2.190; drop Video enum-variant edgecases Aug 30, 2021
Vulkan 1.2.188 removed the only occurence of `ename:`, which was our
heuristic to find a type that's a pointer to a static-sized array.  It
is now replaced with a "normal" `latexmath:` expression, but should
still be dealt with appropriately.

Note that all `latexmath:` conditions have been removed, as these fields
should not be silently omitted.  As of this Vulkan version only 3 exist,
and all have their own edge-case.
This reverts commit 43dee26.

Upstream is reverting back to inconsistent paths in [this commit] to
counter unintentional header `#include` changes on the C-side:
KhronosGroup/Vulkan-Docs#1573

[this commit]: KhronosGroup/Vulkan-Docs@8bde11c
Every `#include` path (except `"vk_platform.h"`, see previous commit) is
relative to the `include/` directory or the current file, and does not
look for a path relative to `include/vulkan/`.
@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.2.190; drop Video enum-variant edgecases Update Vulkan-Headers to 1.2.191; drop Video enum-variant edgecases Sep 7, 2021
@MaikKlein
Copy link
Member

If the next updates/PRs are interesting, should we go and push a patch release anyway at risk of breaking someones experimental workflow for a bit?

I think that is fine. Can't expect stability guarantees for provisional extensions. Of course would be better to have it behind a toggle at one point.

@MarijnS95
Copy link
Collaborator Author

Of course would be better to have it behind a toggle at one point.

Yup, maybe need to have another crack at that some time soon; it's a known flaw in our API for now.

@MarijnS95 MarijnS95 merged commit 19c5d45 into ash-rs:master Sep 8, 2021
@MarijnS95 MarijnS95 deleted the update branch September 8, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants