Add Packed24_8 helper-type for constructing AS Instance bitfields
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expenses
reviewed
Sep 25, 2021
|
I think using a custom type is more idiomatic, and conveys to the user that it's not just a single integer. If the inner |
Much like `platform_types.rs` `vk.rs` does not contain any generated code that depends on `Vulkan-Headers`' `vk.xml`, making it easier to just keep this file manually editable.
MarijnS95
force-pushed
the
as-instance-bitfield
branch
from
811a81b to
0b0c06e
Compare
MarijnS95
changed the title
Packed24_8 helper-type for constructing AS Instance bitfields
|
@Rua Yup, got it done :) Regarding making |
MaikKlein
requested changes
Sep 27, 2021
MarijnS95
force-pushed
the
as-instance-bitfield
branch
from
0b0c06e to
802fdd5
Compare
MaikKlein
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #474, cc @expenses
Draft because we can possibly improve API design here by making a special type instead of
u32that has this as a constructor? This doesn't include a full builder yet, but if we do anything more fancy than this we should move these types to a new file directly included inash/vk/instead of having static text (that doesn't depend on anything from the autogeneration process) hardcoded in the generator.