Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vulkan-Headers to 1.2.198 #477

Merged
merged 7 commits into from
Nov 9, 2021
Merged

Update Vulkan-Headers to 1.2.198 #477

merged 7 commits into from
Nov 9, 2021

Conversation

MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 commented Sep 28, 2021 •
edited
Loading

No description provided.

MarijnS95
MarijnS95 commented Sep 29, 2021
View reviewed changes
generator/src/lib.rs
Comment on lines 1392 to +1393
let vendors = [
"_NVX", "_KHR", "_EXT", "_NV", "_AMD", "_ANDROID", "_GOOGLE", "_INTEL",
"_NVX", "_KHR", "_EXT", "_NV", "_AMD", "_ANDROID", "_GOOGLE", "_INTEL", "_FUCHSIA",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementing the TODO just above (// TODO: Should be read from vk.xml id:2) is really ugly:

https://github.com/Traverse-Research/ash/compare/vendor-tags

Makes me want to see in what state generator2 is and continue working on that, in hopes of having a more clear parsing -> immediate representation with context -> write out to disk instead of all these HashSets and HashMaps passed all over the place.

@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.2.194 Update Vulkan-Headers to 1.2.195 Oct 5, 2021
@MarijnS95
Copy link
Collaborator Author

With the addition of VK_EXT_rgba10x6_formats, VK_KHR_format_feature_flags2 and VK_KHR_maintenance4 this seems like a good moment to update and release ash. After merging this PR I can submit the extension for maintenance4 so that we have the new commands covered from the get-go.

@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.2.195 Update Vulkan-Headers to 1.2.196 Oct 14, 2021
@MarijnS95
Copy link
Collaborator Author

MarijnS95 commented Oct 14, 2021 •
edited
Loading

Currently blocking on KhronosGroup/Vulkan-Headers#236 resolved.

@MarijnS95
Update Vulkan-Headers to 1.2.192
d191271
@MarijnS95
Update Vulkan-Headers to 1.2.193
57d7991
@MarijnS95
Update Vulkan-Headers to 1.2.194
ec65b41
@MarijnS95
Update Vulkan-Headers to 1.2.195
3701f95 
Includes the new VK_EXT_rgba10x6_formats, VK_KHR_format_feature_flags2
and VK_KHR_maintenance4 extensions.
@MarijnS95
Update Vulkan-Headers to 1.2.196
cc69841 
Includes Vulkan-Headers fixup commit with the missing h265 encode
header.
@MarijnS95
Update Vulkan-Headers to 1.2.197
7219d5c
@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.2.196 Update Vulkan-Headers to 1.2.197 Nov 3, 2021
@MarijnS95 MarijnS95 mentioned this pull request Nov 3, 2021
Open
55 tasks
@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.2.197 Update Vulkan-Headers to 1.2.198 Nov 9, 2021
@MarijnS95 MarijnS95 merged commit 3947675 into ash-rs:master Nov 9, 2021
@MarijnS95 MarijnS95 deleted the update branch November 9, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasper-Bekkers Jasper-Bekkers Jasper-Bekkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarijnS95 @Jasper-Bekkers