Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extensions: Add VK_KHR_present_wait #493

Merged
merged 1 commit into from
Nov 19, 2021
Merged

extensions: Add VK_KHR_present_wait #493

merged 1 commit into from
Nov 19, 2021

Conversation

filnet
Copy link
Contributor

@filnet filnet commented Nov 12, 2021

No description provided.

@filnet filnet force-pushed the present_wait_extension branch 2 times, most recently from 8ffb2d4 to 6d3c9df Compare November 12, 2021 12:13
@filnet
Copy link
Contributor Author

filnet commented Nov 12, 2021

Please merge this PR so I can include this new extension in the upcoming cleanup PR.

@MarijnS95
Copy link
Collaborator

Feel free to fix that in this PR instead, so that this extension is introduced with the clean way of doing things from the get-go.

@filnet
Copy link
Contributor Author

filnet commented Nov 12, 2021

Feel free to fix that in this PR instead, so that this extension is introduced with the clean way of doing things from the get-go.

Will do.

@filnet
Copy link
Contributor Author

filnet commented Nov 12, 2021 •
edited
Loading

What is preferred :

self.fns
    .wait_for_present_khr(
        self.handle,
        swapchain,
        present_id,
        timeout.as_nanos().try_into().unwrap(),
    )
    .result()

or

let timeout_ns = timeout.as_nanos().try_into().unwrap();
self.fns
    .wait_for_present_khr(self.handle, swapchain, present_id, timeout_ns)
    .result()

?

@filnet
Copy link
Contributor Author

filnet commented Nov 12, 2021

I updated the 2nd choice to not alias timeout...

@filnet filnet force-pushed the present_wait_extension branch from 6d3c9df to f24d5a8 Compare November 12, 2021 15:10
filnet added a commit to filnet/ash that referenced this pull request Nov 12, 2021
@filnet
extensions: make naming and layout consistent accross all extensions
e3b2b29 
breaking change:
- some extensions were exposing instance() instead of device()

includes:
- renaming function pointer member to fns
- moving name(), fp(), device()/instance() functions at end of file
- adding missing device()/instance() functions
- using result() instead of into()

see ash-rs#493
filnet added a commit to filnet/ash that referenced this pull request Nov 12, 2021
@filnet
remove From<vk::Result> for VkResult
61b7735 
this is a breaking change

see ash-rs#493
@filnet filnet mentioned this pull request Nov 12, 2021
Merged
@filnet filnet force-pushed the present_wait_extension branch from f24d5a8 to 2392e58 Compare November 12, 2021 15:46
filnet added a commit to filnet/ash that referenced this pull request Nov 12, 2021
@filnet
extensions: make naming and layout consistent accross all extensions
8cb24ab 
breaking change:
- some extensions were exposing instance() instead of device()

includes:
- renaming function pointer member to fns
- moving name(), fp(), device()/instance() functions at end of file
- adding missing device()/instance() functions
- using result() instead of into()

see ash-rs#493
filnet added a commit to filnet/ash that referenced this pull request Nov 12, 2021
@filnet
extensions: make naming and layout consistent accross all extensions
d26d6db 
breaking change:
- some extensions were exposing instance() instead of device()

includes:
- renaming function pointer member to fns
- moving name(), fp(), device()/instance() functions at end of file
- adding missing device()/instance() functions
- using result() instead of into()

see ash-rs#493
filnet added a commit to filnet/ash that referenced this pull request Nov 12, 2021
@filnet
extensions: make naming and layout consistent accross all extensions
cda2c50 
breaking change:
- some extensions were exposing instance() instead of device()

includes:
- renaming function pointer member to fns
- moving name(), fp(), device()/instance() functions at end of file
- adding missing device()/instance() functions
- using result() instead of into()

see ash-rs#493
@MarijnS95 MarijnS95 mentioned this pull request Nov 15, 2021
Closed
@MarijnS95
Copy link
Collaborator

@filnet IMO aliasing is preferred, as is calling the function right in the expression - but following the comments in #496 I'm not sure if we should use Duration after all.

@filnet filnet force-pushed the present_wait_extension branch 2 times, most recently from 099880f to 30db727 Compare November 15, 2021 21:31
@filnet filnet force-pushed the present_wait_extension branch from 30db727 to 4bb7436 Compare November 15, 2021 21:34
filnet added a commit to filnet/ash that referenced this pull request Nov 15, 2021
@filnet
extensions: make naming and layout consistent accross all extensions
bb29817 
breaking change:
- some extensions were exposing `instance()` instead of `device()`

includes:
- renaming function pointer member to `fns`
- moving `name()`, `fp(`), `device()`/`instance()` functions at end of file
- adding missing `device()`/`instance()` functions
- using `result()` instead of `into()`

see ash-rs#493
Ralith pushed a commit that referenced this pull request Nov 16, 2021
@filnet @Ralith
remove From<vk::Result> for VkResult
2f51478 
this is a breaking change

see #493
filnet added a commit to filnet/ash that referenced this pull request Nov 16, 2021
@filnet
extensions: make naming and layout consistent accross all extensions
cb41ef9 
breaking change:
- some extensions were exposing `instance()` instead of `device()`

includes:
- renaming function pointer member to `fns`
- moving `name()`, `fp(`), `device()`/`instance()` functions at end of file
- adding missing `device()`/`instance()` functions
- using `result()` instead of `into()`

see ash-rs#493
filnet added a commit to filnet/ash that referenced this pull request Nov 16, 2021
@filnet
extensions: make naming and layout consistent accross all extensions
6eef4c7 
breaking change:
- some extensions were exposing `instance()` instead of `device()`

includes:
- renaming function pointer member to `fns`
- moving `name()`, `fp(`), `device()`/`instance()` functions at end of file
- adding missing `device()`/`instance()` functions

see ash-rs#493
MarijnS95
MarijnS95 approved these changes Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for the wait!

@MarijnS95 MarijnS95 merged commit 9e14786 into ash-rs:master Nov 19, 2021
filnet added a commit to filnet/ash that referenced this pull request Nov 19, 2021
@filnet
extensions: make naming and layout consistent accross all extensions
5f8506b 
breaking change:
- some extensions were exposing `instance()` instead of `device()`

includes:
- renaming function pointer member to `fns`
- moving `name()`, `fp(`), `device()`/`instance()` functions at end of file
- adding missing `device()`/`instance()` functions

see ash-rs#493
filnet added a commit to filnet/ash that referenced this pull request Nov 19, 2021
@filnet
extensions: Make naming and layout consistent accross all extensions
86b3e5c 
breaking change:
- some extensions were exposing `instance()` instead of `device()`

includes:
- renaming function pointer member to `fns`
- moving `name()`, `fp(`), `device()`/`instance()` functions at end of file
- adding missing `device()`/`instance()` functions

see ash-rs#493
filnet added a commit to filnet/ash that referenced this pull request Nov 20, 2021
@filnet
extensions: Make naming and layout consistent accross all extensions
f744afd 
breaking change:
- some extensions were exposing `instance()` instead of `device()`

includes:
- renaming function pointer member to `fns`
- moving `name()`, `fp(`), `device()`/`instance()` functions at end of file
- adding missing `device()`/`instance()` functions

see ash-rs#493
filnet added a commit to filnet/ash that referenced this pull request Nov 23, 2021
@filnet
extensions: Make naming and layout consistent accross all extensions
5568e0f 
breaking change:
- some extensions were exposing `instance()` instead of `device()`

includes:
- renaming function pointer member to `fns`
- moving `name()`, `fp(`), `device()`/`instance()` functions at end of file
- adding missing `device()`/`instance()` functions

see ash-rs#493
MarijnS95 pushed a commit that referenced this pull request Dec 11, 2021
@filnet
extensions: make naming and layout consistent across all extensions (#…
289a57e 
…494)

* extensions: Make naming and layout consistent across all extensions

breaking change:
- some extensions were exposing `instance()` instead of `device()`

includes:
- renaming function pointer member to `fns`
- moving `name()`, `fp(`), `device()`/`instance()` functions at end of file
- adding missing `device()`/`instance()` functions

see #493

* debug_marker: Remove unneeded `device` from `debug_marker_set_object_name()`

* extensions: Remove unneeded `instance` and `device` struct members and functions

* extensions: renamed all `fns` fields to `fp` to match `pub fn fp()` getter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 MarijnS95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filnet @MarijnS95