extensions: Group enum extension variants together per impl T block
#519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of generating an impl block - together with "Generated from XXX" doc - for every single item that extends an enum type, group all these extensions together in a single `impl` block per extension per type. This cuts down a couple thousand lines of repeated `impl T` and `#[doc]` annotations, and makes the code more readable at the same time: it is now possible to immediately see exactly all the constants that a certain extension extends a type with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating an impl block - together with "Generated from XXX" doc - for every single item that extends an enum type, group all these extensions together in a single
implblock per extension per type.This cuts down a couple thousand lines of repeated
impl Tand#[doc]annotations, and makes the code more readable at the same time: it is now possible to immediately see exactly all the constants that a certain extension extends a type with.