examples: Use c_char for pointer to raw string #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On platforms like Android strings use `u8` as character-type instead of `i8` - using the appropriate `c_char` type hides this discrepancy and allows the examples to compile for all platforms.
MarijnS95
force-pushed
the
examples-c_char
branch
from
cfe2110 to
03ca699
Compare
Ralith
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms like Android strings use
u8as character-type instead ofi8- using the appropriatec_chartype hides this discrepancy and allows the examples to compile for all platforms.Closes #315 (EDIT: GH can only link and close issues this way, not other PRs)
Opening a separate PR because that one hasn't moved for 1.5 years, even after repeated asking to replace the
s/i8/u8(which obviously breaks all other platforms) withc_char.